kramerul commented on code in PR #4100:
URL: https://github.com/apache/calcite/pull/4100#discussion_r1950695100
##########
core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcCatalogSchema.java:
##########
@@ -103,34 +143,25 @@ public static JdbcCatalogSchema create(
return new JdbcCatalogSchema(dataSource, dialect, convention, catalog);
}
- private SubSchemaMap computeSubSchemaMap() {
- final ImmutableMap.Builder<String, Schema> builder =
- ImmutableMap.builder();
- @Nullable String defaultSchemaName;
- try (Connection connection = dataSource.getConnection();
- ResultSet resultSet =
- connection.getMetaData().getSchemas(catalog, null)) {
- defaultSchemaName = connection.getSchema();
- while (resultSet.next()) {
- final String schemaName =
- requireNonNull(resultSet.getString(1),
- "got null schemaName from the database");
- builder.put(schemaName,
- new JdbcSchema(dataSource, dialect, convention, catalog,
schemaName));
- }
+ @Override public Lookup<Table> tables() {
+ return Lookup.empty();
+ }
+
+ @Override public Lookup<? extends Schema> subSchemas() {
Review Comment:
The invalidation is happening after one minute as I described in my comment
to class `LoadingCacheLookup`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
