kramerul commented on PR #4100: URL: https://github.com/apache/calcite/pull/4100#issuecomment-2652752867
> Has any benchmarking been done to prove the efficiency of this approach? I am not an expert in this part of the code, but the PR looks pretty good to me. I have only made "syntactic" comments. This PR only improves performance for huge database. We are using a database with more than 500000 schemas containing up to 500000 tables. In such an environment, it takes more than 10 seconds to load all table names from the database. Formerly, this was necessary during the preparation of each query. With the new approach, only the involved tables are loaded from the database. This speeds up the preparation by factors. It also takes much less memory, because it's no longer necessary to hold a list of all tables in memory (snapshot). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
