xuzifu666 commented on code in PR #4218:
URL: https://github.com/apache/calcite/pull/4218#discussion_r1973664184
##########
druid/src/main/java/org/apache/calcite/adapter/druid/DruidJsonFilter.java:
##########
@@ -294,11 +291,11 @@ abstract class DruidJsonFilter implements DruidJson {
if (columnName == null) {
return null;
}
- if (e.getKind() != SqlKind.NOT_IN) {
+ if (e.getKind() == SqlKind.DRUID_IN) {
return new DruidJsonFilter.JsonInFilter(columnName, listBuilder.build(),
extractionFunction);
} else {
- return toNotDruidFilter(
- new DruidJsonFilter.JsonInFilter(columnName, listBuilder.build(),
extractionFunction));
+ return new DruidJsonFilter.JsonNotInFilter(columnName,
Review Comment:
I had remove JsonNotInFilter class, and as you suggesstion I thought not
need this new class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
