xuzifu666 commented on code in PR #4218:
URL: https://github.com/apache/calcite/pull/4218#discussion_r1973664543
##########
druid/src/main/java/org/apache/calcite/adapter/druid/DruidJsonFilter.java:
##########
@@ -627,6 +625,34 @@ protected JsonInFilter(String dimension, List<String>
values,
}
}
+ /**
Review Comment:
Had removed it.
##########
druid/src/test/java/org/apache/calcite/adapter/druid/DruidQueryFilterTest.java:
##########
@@ -87,6 +87,30 @@ class DruidQueryFilterTest {
+ "\"values\":[\"1\",\"5\",\"value1\"]}"));
}
+ @Test void testNotInFilter() throws IOException {
+ final Fixture f = new Fixture();
+ final List<? extends RexNode> listRexNodes =
+ ImmutableList.of(f.rexBuilder.makeInputRef(f.varcharRowType, 0),
+ f.rexBuilder.makeExactLiteral(BigDecimal.valueOf(1)),
+ f.rexBuilder.makeExactLiteral(BigDecimal.valueOf(5)),
+ f.rexBuilder.makeLiteral("value1"));
+
+ RexNode inRexNode =
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
