xiedeyantu commented on code in PR #4209:
URL: https://github.com/apache/calcite/pull/4209#discussion_r1981485392
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -244,6 +245,33 @@ private static String toSql(RelNode root, SqlDialect
dialect,
sql(query).withMysql().ok(expected);
}
+ /**
+ * Test case of
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6836";>[CALCITE-6836]
+ * Add Rule to convert INTERSECT to EXISTS</a>. */
+ @Test void testIntersectToExistsRule() {
+ String query = "SELECT \"product_name\"\n"
Review Comment:
> In fact, I don't think it's necessary to test in RelToSqlConverter because
the semantics of relational algebra is already expressed in RelNode. What is
tested here is the correctness of RelNode -> sqlnode -> sqlText.
@suibianwanwank Thanks, I agree with you, but currently Calcite may not have
the ability to execute this plan, and I have no other good options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
