mihaibudiu commented on code in PR #4253:
URL: https://github.com/apache/calcite/pull/4253#discussion_r2004338199
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -3890,11 +3893,14 @@ private SqlDialect nonOrdinalDialect() {
+ "FROM `foodmart`.`product`";
final String expectedSpark = "SELECT CAST(`product_id` AS CHAR(1))\n"
+ "FROM `foodmart`.`product`";
+ final String expectedClickHouse = "SELECT CAST(`product_id` AS
`FixedString(1)`)\n"
Review Comment:
assuming this indeed works in Clickhouse, this PR looks fine.
Has this been tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
