Re: [PR] [CALCITE-6900] Support Char type cast in ClickHouse Dialect [calcite]

Tue, 25 Mar 2025 05:01:35 -0700 


xuzifu666 commented on code in PR #4253:
URL: https://github.com/apache/calcite/pull/4253#discussion_r2006935672


##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -3890,11 +3893,14 @@ private SqlDialect nonOrdinalDialect() {
         + "FROM `foodmart`.`product`";
     final String expectedSpark = "SELECT CAST(`product_id` AS CHAR(1))\n"
         + "FROM `foodmart`.`product`";
+    final String expectedClickHouse = "SELECT CAST(`product_id` AS 
`FixedString(1)`)\n"

Review Comment:
   
![1742538835661.png](https://github.com/user-attachments/assets/d336ea2e-2cd9-40be-9cec-2f41bb8b9192)
   @mihaibudiu It is the test in my repository and related CI is all passed and 
based with main branch latest commit.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to