mihaibudiu commented on code in PR #4236:
URL: https://github.com/apache/calcite/pull/4236#discussion_r2008119369
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -3925,6 +3926,28 @@ public void checkOrderBy(final boolean desc,
.returnsUnordered("empid=150; name=Sebastian");
}
+ /** Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-6904";>
+ * [CALCITE-6904] IS_NOT_DISTINCT_FROM is converted error in
ElementerableJoinRule</a>. */
+ @Disabled("CALCITE-6904")
+ @Test void testIntersectToSemiJoin() {
+ final String sql = ""
+ + "select \"commission\" from \"hr\".\"emps\"\n"
+ + "intersect\n"
+ + "select \"commission\" from \"hr\".\"emps\" where \"empid\">=150";
+ CalciteAssert.hr()
+ .query(sql)
+ .withHook(Hook.PLANNER, (Consumer<RelOptPlanner>)
+ planner -> {
+ planner.removeRule(CoreRules.INTERSECT_TO_DISTINCT);
Review Comment:
can you just remove this new rule here as well and not disable the test?
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -3925,6 +3926,28 @@ public void checkOrderBy(final boolean desc,
.returnsUnordered("empid=150; name=Sebastian");
}
+ /** Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-6904";>
+ * [CALCITE-6904] IS_NOT_DISTINCT_FROM is converted error in
ElementerableJoinRule</a>. */
Review Comment:
there is no Elementerable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
