xiedeyantu commented on code in PR #4260:
URL: https://github.com/apache/calcite/pull/4260#discussion_r2010990409
##########
core/src/main/java/org/apache/calcite/rel/core/JoinInfo.java:
##########
@@ -50,30 +52,59 @@ public class JoinInfo {
/** Creates a JoinInfo. */
protected JoinInfo(ImmutableIntList leftKeys, ImmutableIntList rightKeys,
- ImmutableList<RexNode> nonEquiConditions) {
- this.leftKeys = requireNonNull(leftKeys, "leftKeys");
- this.rightKeys = requireNonNull(rightKeys, "rightKeys");
- this.nonEquiConditions =
- requireNonNull(nonEquiConditions, "nonEquiConditions");
+ ImmutableList<RexNode> nonEquiConditions, ImmutableList<Boolean>
filterNulls,
Review Comment:
In EnumerableJoinRule, JoinInfo is used to split the Equi and non-equi
conditions, and then the two are combined as the join condition. And then will
use HashJoin. If it does not do such a split, it is fine to use NestedLoopJoin
directly with the original join condition.This question does involve a lot of
points. I don't know if I have made it clear this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
