xiedeyantu commented on code in PR #4260:
URL: https://github.com/apache/calcite/pull/4260#discussion_r2011028815
##########
core/src/main/java/org/apache/calcite/rel/core/JoinInfo.java:
##########
@@ -50,30 +52,59 @@ public class JoinInfo {
/** Creates a JoinInfo. */
protected JoinInfo(ImmutableIntList leftKeys, ImmutableIntList rightKeys,
- ImmutableList<RexNode> nonEquiConditions) {
- this.leftKeys = requireNonNull(leftKeys, "leftKeys");
- this.rightKeys = requireNonNull(rightKeys, "rightKeys");
- this.nonEquiConditions =
- requireNonNull(nonEquiConditions, "nonEquiConditions");
+ ImmutableList<RexNode> nonEquiConditions, ImmutableList<Boolean>
filterNulls,
Review Comment:
So you mean that it is reasonable for us to modify the execution logic of
hashjoin? You said before that we should not change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
