xiedeyantu commented on code in PR #4260:
URL: https://github.com/apache/calcite/pull/4260#discussion_r2013323920
##########
core/src/main/java/org/apache/calcite/rel/core/JoinInfo.java:
##########
@@ -66,8 +66,36 @@ public static JoinInfo of(RelNode left, RelNode right,
RexNode condition) {
final List<RexNode> nonEquiList = new ArrayList<>();
RelOptUtil.splitJoinCondition(left, right, condition, leftKeys, rightKeys,
filterNulls, nonEquiList);
- return new JoinInfo(ImmutableIntList.copyOf(leftKeys),
- ImmutableIntList.copyOf(rightKeys), ImmutableList.copyOf(nonEquiList));
+
+ /**
+ * In join implementation when the condition is equality (=),
+ * we filter out nulls prior to the join. If the condition is
Review Comment:
You are right, this description should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
