xiedeyantu commented on code in PR #4260: URL: https://github.com/apache/calcite/pull/4260#discussion_r2015292104
########## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ########## @@ -425,6 +425,7 @@ import static org.apache.calcite.sql.fun.SqlStdOperatorTable.IS_JSON_SCALAR; import static org.apache.calcite.sql.fun.SqlStdOperatorTable.IS_JSON_VALUE; import static org.apache.calcite.sql.fun.SqlStdOperatorTable.IS_NOT_A_SET; +import static org.apache.calcite.sql.fun.SqlStdOperatorTable.IS_NOT_DISTINCT_FROM; Review Comment: IS_DISTINCT_FROM will expand to `x=y IS NOT TRUE and ((x is not null) or (y is not null))`. There is currently no method to collapse it, so it may not be necessary to implement it temporarily. If necessary, I can add one, but it may not be called by any method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
