xiedeyantu commented on code in PR #4280: URL: https://github.com/apache/calcite/pull/4280#discussion_r2029446365
########## core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml: ########## @@ -6357,6 +6357,144 @@ LogicalProject(EMPNO=[$3], ENAME=[$4], JOB=[$5], MGR=[$6], HIREDATE=[$7], SAL=[$ LogicalJoin(condition=[true], joinType=[inner]) LogicalTableScan(table=[[scott, EMP]]) LogicalTableScan(table=[[scott, DEPT]]) +]]> Review Comment: This is a very good suggestion. I also thought about it when writing the test. Is there any existing test framework that can support this kind of logic? I don’t seem to have found it. Do I need to make an extension for JdbcTest? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
