mihaibudiu commented on code in PR #4280: URL: https://github.com/apache/calcite/pull/4280#discussion_r2029452486
########## core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml: ########## @@ -6357,6 +6357,144 @@ LogicalProject(EMPNO=[$3], ENAME=[$4], JOB=[$5], MGR=[$6], HIREDATE=[$7], SAL=[$ LogicalJoin(condition=[true], joinType=[inner]) LogicalTableScan(table=[[scott, EMP]]) LogicalTableScan(table=[[scott, DEPT]]) +]]> Review Comment: Yes, I think JdbcTest is the only place where you can do this right now, although it's a cumbersome process. I wonder whether there is any support for differential testing, so you don't have to use returnsUnordered. Ideally you would compute the result using the existing rules, and compare to the result obtained using the new rules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
