mihaibudiu commented on code in PR #4260:
URL: https://github.com/apache/calcite/pull/4260#discussion_r2021570408
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -3950,6 +3950,24 @@ public void checkOrderBy(final boolean desc,
.returnsUnordered("empid=150; name=Sebastian");
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6904";>[CALCITE-6904]
Review Comment:
Can you change the JIRA title, the commit title and the PR title to:
"IS_NOT_DISTINCT_FROM is incorrectly handled by EnumerableJoinRule"?
##########
core/src/main/java/org/apache/calcite/rel/core/JoinInfo.java:
##########
@@ -70,6 +70,22 @@ public static JoinInfo of(RelNode left, RelNode right,
RexNode condition) {
ImmutableIntList.copyOf(rightKeys), ImmutableList.copyOf(nonEquiList));
}
+ /** Creates a {@code JoinInfo} by analyzing a condition.
+ * This method will only convert EQUALS condition considers it as an equi
condition.
Review Comment:
Let's rephrase this slightly: "A JoinInfo created using this method only
considers EQUALS operations equi-conditions; in contrast IS_NOT_DISTINCT_FROM
operations are NOT considered equalities; they are inserted in the nonEquiList.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
