mihaibudiu commented on code in PR #4260:
URL: https://github.com/apache/calcite/pull/4260#discussion_r2017706520
##########
core/src/main/java/org/apache/calcite/rel/core/JoinInfo.java:
##########
@@ -62,10 +62,9 @@ protected JoinInfo(ImmutableIntList leftKeys,
ImmutableIntList rightKeys,
public static JoinInfo of(RelNode left, RelNode right, RexNode condition) {
final List<Integer> leftKeys = new ArrayList<>();
final List<Integer> rightKeys = new ArrayList<>();
- final List<Boolean> filterNulls = new ArrayList<>();
final List<RexNode> nonEquiList = new ArrayList<>();
RelOptUtil.splitJoinCondition(left, right, condition, leftKeys, rightKeys,
- filterNulls, nonEquiList);
+ null, nonEquiList);
Review Comment:
Yes, but I would name the function `createWithStrictEquality`, or something
like this, and explain how it differs from `of`.
I think that if all the tests pass you are fine - if you don't change public
interfaces.
After your change `JoinInfo` will represent two slightly different data
structures, depending on how it's created, so it is very important to document
clearly how the result created by `of` differs from the result created by your
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
