xiedeyantu commented on PR #4303: URL: https://github.com/apache/calcite/pull/4303#issuecomment-2803280191
> > > Test cases that do not belong to the Logical plan need to be included. > > > > > > This is a great suggestion. However, it's a bit tricky because all SQL are converted into "logical" plans. Could you give me some advice? > > Why did you make this change? You must have a scenario in mind where Logical is wrong. Can you create a short reproduction for that scenario? I saw this jira question and I think it is appropriate. It may not be wrong to use "logical", but it can be extended to non-"logical" operators. NobiGo's suggestion is good, but I haven't found a good way to write a case yet. For example, plans are all Enumerable operators. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
