xiedeyantu commented on code in PR #4303:
URL: https://github.com/apache/calcite/pull/4303#discussion_r2048359865
##########
core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java:
##########
@@ -288,8 +290,16 @@ private CoreRules() {}
/** Rule that pushes a {@link LogicalFilter}
* past a {@link LogicalTableFunctionScan}. */
public static final FilterTableFunctionTransposeRule
- FILTER_TABLE_FUNCTION_TRANSPOSE =
- FilterTableFunctionTransposeRule.Config.DEFAULT.toRule();
+ LOGICAL_FILTER_LOGICAL_TABLE_FUNCTION_TRANSPOSE = Config.DEFAULT
+ .withOperandFor(LogicalFilter.class, LogicalTableFunctionScan.class)
Review Comment:
Because I saw Julian mention this statement in JIRA: "Perhaps retain an
instance of the rule that continues to match only LogicalFilter and
LogicalTableScan, and also add a new instance that is generic." Therefore, I
kept a Logical_X rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
