silundong commented on PR #4324: URL: https://github.com/apache/calcite/pull/4324#issuecomment-2827049541
> > > LGTM but I feel there is some redundancy with the previous rules that could be easily reduced, could you give it a shot @silundong? > > > > > > Sorry, I didn’t understand that. Could you elaborate a little bit? > > I have reviewed [CALCITE-6914](https://issues.apache.org/jira/browse/CALCITE-6914) as well and lots of the code implemented here is nearly identical to code provided there, I am wondering if we could abstract some parts a bit and re-use them here. I haven't tried to do that, it would be great if you could take a look and give it a shot if it sounds doable. Yes, they are similar. However, their logic in splitting predicates is not consistent (single table/same side of Join inputs), so it may not be easy to reuse, but I will try it. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
