asolimando commented on code in PR #4324:
URL: https://github.com/apache/calcite/pull/4324#discussion_r2059987868
##########
core/src/main/java/org/apache/calcite/rex/RexUtil.java:
##########
@@ -2799,6 +2800,172 @@ private RexNode or(Iterable<? extends RexNode> nodes) {
}
}
+ /**
+ * Helper class that expands predicates from disjunctions(splited by K).
+ *
+ * @param <K> The type used to split the predicates.
Review Comment:
I'd reference to `K` as "an input source K" or similar, which can be a table
or a join depending on how the rule is being instantiated. I don't feel
strongly about the name, but I think we need to characterize more precisely
what this `K` means, I understand what this means only because I have seen the
code already, I feel it's too abstract as it's phrased now
##########
core/src/main/java/org/apache/calcite/rex/RexUtil.java:
##########
@@ -2799,6 +2800,172 @@ private RexNode or(Iterable<? extends RexNode> nodes) {
}
}
+ /**
+ * Helper class that expands predicates from disjunctions(splited by K).
Review Comment:
```suggestion
* Helper class that expands predicates from disjunctions (splitted by K).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
