NobiGo commented on code in PR #4331:
URL: https://github.com/apache/calcite/pull/4331#discussion_r2059430199
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -8268,22 +8268,27 @@ private void checkLiteral2(String expression, String
expected) {
sql(query2).ok(expected2);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6982";>[CALCITE-6982]
+ * Removes cast from string also support with IS_NULL/IS_NOT_NULL</a>. */
@Test void testCastInStringIntegerComparison() {
final String query = "select \"employee_id\" "
+ "from \"foodmart\".\"employee\" "
- + "where 10 = cast('10' as int) and \"birth_date\" = cast('1914-02-02'
as date) or "
+ + "where 10 is distinct from cast('10' as int) and 10 = cast('10' as
int) and \"birth_date\" = cast('1914-02-02' as date) or "
Review Comment:
Please add a new test case to verify this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
