xuzifu666 commented on code in PR #4331:
URL: https://github.com/apache/calcite/pull/4331#discussion_r2059540589
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -350,6 +350,15 @@ public static SqlNode convertConditionToSqlNode(RexNode
node,
*/
private static RexNode stripCastFromString(RexNode node, SqlDialect dialect)
{
switch (node.getKind()) {
+ case IS_NULL:
+ case IS_NOT_NULL:
+ final RexCall call0 = (RexCall) node;
+ final RexNode o = call0.operands.get(0);
+ if (o.getKind() == SqlKind.CAST) {
Review Comment:
Basic type conversion cast(var as type) seems would not be null when var is
not null (such as numberic, date, string, nested type), and I would do more
research about it, thanks~ @mihaibudiu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
