suibianwanwank commented on code in PR #4332:
URL: https://github.com/apache/calcite/pull/4332#discussion_r2061395435
##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -3201,6 +3210,59 @@ assert allLessThan(this.oldToNewOutputs.values(),
}
}
+ /**
+ * This method checks if the field at the given index is non-nullable. If it
is non-nullable,
Review Comment:
Actually, we don’t need this method to guarantee correctness. Using `IS NOT
DISTINCT FROM` will always give the correct result. The check for nullable
fields is just an attempt to replace `IS NOT DISTINCT FROM` with `EQUAL` in
some basic cases where we can ensure NULL values have already been filtered out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
