suibianwanwank commented on code in PR #4332:
URL: https://github.com/apache/calcite/pull/4332#discussion_r2061485900
##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -1424,11 +1425,19 @@ private static boolean isWidening(RelDataType type,
RelDataType type1) {
}
final int newLeftPos =
requireNonNull(leftFrame.oldToNewOutputs.get(corDef.field));
final int newRightPos = rightOutput.getValue();
- conditions.add(
- relBuilder.equals(RexInputRef.of(newLeftPos, newLeftOutput),
- new RexInputRef(newLeftFieldCount + newRightPos,
- newRightOutput.get(newRightPos).getType())));
+ // TODO: If we have similar rules, perhaps it can be applied externally
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
