suibianwanwank commented on code in PR #4354:
URL: https://github.com/apache/calcite/pull/4354#discussion_r2071242986
##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -5679,4 +5679,11 @@ void checkUserDefinedOrderByOver(NullCollation
nullCollation) {
String sql = "SELECT CAST(CAST(? AS INTEGER) AS CHAR)";
sql(sql).ok();
}
+
+ @Test void testJoinOnConditionWithSubquery() {
Review Comment:
@xiedeyantu, can you add this test , I think it may not pass the test .
```
@Test void testJoinOnConditionWithSubquery2() {
final String sql = "select t1.* from emp t1\n"
+ "left join dept t2 on t1.deptno = t2.deptno\n"
+ "and t2.deptno in (select t3.ename from emp t3)";
sql(sql).ok();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
