xiedeyantu commented on PR #4354: URL: https://github.com/apache/calcite/pull/4354#issuecomment-2848534300
@mihaibudiu @dssysolyatin @suibianwanwank It may not be possible to simply select one from `bb.inputs` as `bb.root`. If the first operand of the in only involves the `left` or `right` of the `join`, perhaps we can choose one as `bb.root`. If the first operand involves both `left` and `right` (for example, `t1.deptno * t2.deptno in (...)`), but the current `join` has not been created yet, it may require a lot of changes to adapt. I haven't thought of a good way to be compatible with all cases. But this situation can be handled in `SubQueryRemoveRule`. So when encountering this complex case, forcing `expand` to `false` to let the case pass, I don't know if it is a good way to deal with it. If you think it is not good, then I will close this PR first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
