xiedeyantu commented on code in PR #4356:
URL: https://github.com/apache/calcite/pull/4356#discussion_r2073265634
##########
core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java:
##########
@@ -263,41 +261,6 @@ public BigQuerySqlDialect(SqlDialect.Context context) {
}
}
- /**
- * For usage of TRIM, LTRIM and RTRIM in BQ see
- * <a
href="https://cloud.google.com/bigquery/docs/reference/standard-sql/functions-and-operators#trim";>
- * BQ Trim Function</a>.
- */
- private static void unparseTrim(SqlWriter writer, SqlCall call, int leftPrec,
Review Comment:
I noticed that the logic of the `unparseTrim` has also been adjusted here.
Do we need to wait for #4360 to complete before rebasing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
