xuzifu666 commented on code in PR #4356:
URL: https://github.com/apache/calcite/pull/4356#discussion_r2073281301
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -2909,9 +2922,13 @@ private SqlDialect nonOrdinalDialect() {
+ "from \"foodmart\".\"reserve_employee\"";
final String expected = "SELECT TRIM('$@*AABC$@*AADCAA$@*A', '$@*A')\n"
+ "FROM foodmart.reserve_employee";
+ final String expectedSqlite = "SELECT TRIM('$@*AABC$@*AADCAA$@*A',
'$@*A')\n"
+ + "FROM \"foodmart\".\"reserve_employee\"";
sql(query)
.withBigQuery()
- .ok(expected);
Review Comment:
Done, thanks for your careful review. @xiedeyantu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
