mihaibudiu commented on code in PR #4363:
URL: https://github.com/apache/calcite/pull/4363#discussion_r2080700022
##########
core/src/main/java/org/apache/calcite/util/TimestampWithTimeZoneString.java:
##########
@@ -202,4 +212,17 @@ public TimestampString getLocalTimestampString() {
public TimeZone getTimeZone() {
return timeZone;
}
+
+ private static DateTimeUtils.PrecisionTime parseDateTime(String tsStr,
TimeZone timeZone) {
+ DateTimeUtils.PrecisionTime pt =
+ DateTimeUtils.parsePrecisionDateTimeLiteral(tsStr,
requireNonNull(TIMESTAMP_FORMAT.get()),
+ timeZone, -1);
+
+ if (pt == null) {
+ throw RESOURCE.illegalLiteral("TIMESTAMP WITH LOCAL TIME ZONE", tsStr,
Review Comment:
it is very useful for users to be able to see the illegal timestamp, can it
be included in the message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
