xuzifu666 commented on code in PR #4363: URL: https://github.com/apache/calcite/pull/4363#discussion_r2081006190
########## core/src/main/java/org/apache/calcite/util/TimestampWithTimeZoneString.java: ########## @@ -41,21 +46,39 @@ public class TimestampWithTimeZoneString final TimestampString localDateTime; final TimeZone timeZone; final String v; + private final DateTimeUtils.PrecisionTime pt; + + private static final ThreadLocal<@Nullable SimpleDateFormat> TIMESTAMP_FORMAT = Review Comment: We can confirm TimestampWithTimeZoneString##constructor would be call by multiple thread? If not we may not need to use ThreadLocal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
