caicancai commented on code in PR #4356:
URL: https://github.com/apache/calcite/pull/4356#discussion_r2083204026
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7894,10 +7940,12 @@ private void checkLiteral2(String expression, String
expected) {
final String expectedSnowflake = "SELECT LENGTH(\"brand_name\")\n"
+ "FROM \"foodmart\".\"product\"";
final String expectedDuckDB = expectedSnowflake;
+ final String expectedSqlite = expectedDuckDB;
Sql sql = sql(query).withLibrary(SqlLibrary.BIG_QUERY);
sql.withBigQuery().ok(expectedBigQuery);
sql.withSnowflake().ok(expectedSnowflake);
sql.withDuckDB().ok(expectedDuckDB);
+ sql.withSqlite().ok(expectedSqlite);
Review Comment:
withSQLite is more suitable
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -2836,10 +2843,13 @@ private SqlDialect nonOrdinalDialect() {
+ "FROM `foodmart`.`reserve_employee`";
Review Comment:
Above all
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -2897,9 +2910,13 @@ private SqlDialect nonOrdinalDialect() {
+ "FROM foodmart.reserve_employee";
Review Comment:
Above all
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -2816,17 +2817,23 @@ private SqlDialect nonOrdinalDialect() {
.withSpark().ok(expected);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6997";>[CALCITE-6997]
+ * SQLite dialect implementation</a>. */
@Test void testHiveSparkAndBqTrimWithLeading() {
Review Comment:
Did you notice that this method name should be changed to a more appropriate
one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
