xuzifu666 commented on code in PR #4356:
URL: https://github.com/apache/calcite/pull/4356#discussion_r2083212923
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -2816,17 +2817,23 @@ private SqlDialect nonOrdinalDialect() {
.withSpark().ok(expected);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6997";>[CALCITE-6997]
+ * SQLite dialect implementation</a>. */
@Test void testHiveSparkAndBqTrimWithLeading() {
Review Comment:
Yes, I had changed it to a more general test name. @caicancai
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -2836,10 +2843,13 @@ private SqlDialect nonOrdinalDialect() {
+ "FROM `foodmart`.`reserve_employee`";
Review Comment:
done
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -2897,9 +2910,13 @@ private SqlDialect nonOrdinalDialect() {
+ "FROM foodmart.reserve_employee";
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
