asolimando commented on code in PR #4366:
URL: https://github.com/apache/calcite/pull/4366#discussion_r2086122459
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -10511,7 +10511,157 @@ private void
checkLoptOptimizeJoinRule(LoptOptimizeJoinRule rule) {
+ "SELECT mgr, comm FROM emp WHERE comm = 5\n";
sql(sql)
.withPreRule(CoreRules.PROJECT_FILTER_TRANSPOSE)
- .withRule(CoreRules.MINUS_TO_FILTER)
+ .withRule(CoreRules.MINUS_FILTER_TO_FILTER)
+ .check();
+ }
+
+ /** Test case of
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7002";>[CALCITE-7002]
+ * Create an optimization rule to eliminate UNION
+ * from the same source with different filters</a>. */
+ @Test void testMinusToFilterRule3() {
Review Comment:
Can we come up with a more informative suffix than an incremental ID? If
tests are well shaped like in this case, you are adding them as they cover some
specific situation (multiple operands, null values, etc.). It's very
informative to add this into the test name, rather than having the reader to
try to infer it from the example (sometimes it might not be very evident). If
you have a really hard time seeing the difference between one or more test
cases, then it's an indication that they might be redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
