NobiGo commented on code in PR #4355:
URL: https://github.com/apache/calcite/pull/4355#discussion_r2086206020
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -1528,7 +1528,9 @@ private void handleOffsetFetch(@Nullable SqlNode offset,
@Nullable SqlNode fetch
((SqlBasicCall) call).setOperator(overloads.get(0));
}
}
- if (config.callRewrite()) {
+ if (config.callRewrite()
Review Comment:
This modification makes this logic less pure. I assume that when callRewrite
is set to true, the original author intends to rewrite all expressions, not
just under specific conditions. We should ensure that the SQL can still be
executed after the rewrite, except when including nondeterministic functions,
where there might be incorrect results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
