xuzifu666 commented on PR #4369: URL: https://github.com/apache/calcite/pull/4369#issuecomment-2875983954
> > > Sorry, I noticed that there is also an AGGREGATE_VALUES rule that simplifies AGG + VALUES to VALUES. Can we extend this rule? we also paying attention to the `aggCalls` and `groupSets` in the AGG. It might only support scenarios where `groupSets.size() == 1`. > > > > > > Add a new Rule or extend AGGREGATE_VALUES maybe both can resolve the issue, and we can wait for others' suggession~ @xiedeyantu > > IMO, if the existing rule can be expanded with a functionality that has no foreseeable drawbacks, and it doesn't cause any regressions, I think it's preferrable than adding a new rule OK, thanks for suggestion and I would extend it as suggestion. @asolimando @xiedeyantu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
