xuzifu666 commented on PR #4369: URL: https://github.com/apache/calcite/pull/4369#issuecomment-2887121017
> > @asolimando @xiedeyantu Direct modification is a bit troublesomeļ¼so I make a new PR, we can continue in #4371 and this pr would be closed. > > @xuzifu666 we are at 3 PRs for the same ticket, I have the feeling that we (might) have lost of lot of valuable comments along the way. > > Even if we were somehow tracking all questions carefully, when you re-open the PR including the asked modifications, you can't expect people down the line checking multiple PRs to understand the rationale of what was done. > > PRs are very important, not only for reviewing purposes, they are also a written trace of what lead to the code as-is, and it's therefore crucial to keep it clean and accessible, same for the Jira discussions. > > If you are facing issues with git or anything else please ask here (or in the ML) and we can surely help out, tooling can be problematic, there is absolutely no problem with that, feel free to ask. Thanks for your suggestion, I would notice the pr manager in further!@asolimando -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
