silundong commented on code in PR #4392:
URL: https://github.com/apache/calcite/pull/4392#discussion_r2113358733
##########
core/src/main/java/org/apache/calcite/rel/rules/DpHyp.java:
##########
@@ -37,7 +40,12 @@ public class DpHyp {
private final HyperGraph hyperGraph;
- private final HashMap<Long, RelNode> dpTable;
+ private final Map<Long, RelNode> dpTable;
+
+ // record the node order corresponding to the best subgraph, which is used
to convert
+ // the RexNodeAndFieldIndex in hyperedge to the RexInputRef in join
condition, and permute
+ // final result
+ private final Map<Long, ImmutableList<Integer>> resultInputOrder;
Review Comment:
I don't think so. For example, if the graph is fully connected and any
combination is legal, the size of the two map is 2^3-1=7 (the bitmap of 012 and
210 are both 7). For n vertices, I think the maximum number is 2^n-1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
