silundong commented on PR #4392: URL: https://github.com/apache/calcite/pull/4392#issuecomment-2918563812
> No, I don't mean RelOptRulesTests. You need something that looks like unit tests for your code, not for Calcite. For example, when you enumerate candidate plans, it would be nice to validate that these plans are all valid and generate the same result, even if they are not optimal. (Checking that the result is correct may not be easy, though, given the current testing infrastructure.) I completely agree with your point, including your last point, I think it is indeed difficult to complete it in the current testing infrastructure. I don't have a good idea. Maybe create a new test file specifically for testing the execution results of dphyp? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
