xiedeyantu commented on code in PR #4410:
URL: https://github.com/apache/calcite/pull/4410#discussion_r2134963897
##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -5466,6 +5466,63 @@ private ImmutableList<ImmutableBitSet>
cube(ImmutableBitSet... sets) {
.ok();
}
+ @Test void testSelectJoinUsingCommonColumnCaseSensitive() {
+
+ sql("select DEPTNO from emp join dept using (DEPTNO)")
+ .withCaseSensitive(false)
+ .withValidatorIdentifierExpansion(true)
+ .withQuotedCasing(Casing.UNCHANGED)
+ .withUnquotedCasing(Casing.UNCHANGED)
+ .ok();
+
+ sql("select deptno from emp join dept using (deptno)")
+ .withCaseSensitive(false)
+ .withValidatorIdentifierExpansion(true)
+ .withQuotedCasing(Casing.UNCHANGED)
+ .withUnquotedCasing(Casing.UNCHANGED)
+ .ok();
+
+ sql("select DEPTNO from emp join dept using (deptno)")
+ .withCaseSensitive(false)
+ .withValidatorIdentifierExpansion(true)
+ .withQuotedCasing(Casing.UNCHANGED)
+ .withUnquotedCasing(Casing.UNCHANGED)
+ .ok();
+
+ sql("select deptno from emp join dept using (DEPTNO)")
+ .withCaseSensitive(false)
+ .withValidatorIdentifierExpansion(true)
+ .withQuotedCasing(Casing.UNCHANGED)
+ .withUnquotedCasing(Casing.UNCHANGED)
+ .ok();
+ }
+
+ @Test void testNaturalJoinCommonColumn() {
Review Comment:
The same as above.
##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -5466,6 +5466,63 @@ private ImmutableList<ImmutableBitSet>
cube(ImmutableBitSet... sets) {
.ok();
}
+ @Test void testSelectJoinUsingCommonColumnCaseSensitive() {
Review Comment:
Add the jira title to the test case. You can refer to other case. For
example: `/** Test case for...`.
##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -5466,6 +5466,63 @@ private ImmutableList<ImmutableBitSet>
cube(ImmutableBitSet... sets) {
.ok();
}
+ @Test void testSelectJoinUsingCommonColumnCaseSensitive() {
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
