xth-txszy commented on code in PR #4410:
URL: https://github.com/apache/calcite/pull/4410#discussion_r2147509440
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -527,19 +527,29 @@ private boolean expandSelectItem(final SqlNode
selectItem, SqlSelect select,
}
private static SqlNode expandExprFromJoin(SqlJoin join,
- SqlIdentifier identifier, SelectScope scope) {
- if (join.getConditionType() != JoinConditionType.USING) {
+ SqlIdentifier identifier, SelectScope scope, SqlValidatorImpl validator)
{
Review Comment:
The method `expandExprFromJoin` is called by another static method
`expandCommonColumn`.
And the static method `expandCommonColumn` is called in class
`SqlValidatorImpl.SelectExpander` and class
`SqlValidatorImpl.ExtendedExpander`.
So if make method `expandExprFromJoin` non-static, then both method
`expandExprFromJoin` and method `expandCommonColumn` need to be moved to the
class `SqlValidatorImpl.Expander`, which is the super class of class
`SqlValidatorImpl.SelectExpander` and class
`SqlValidatorImpl.ExtendedExpander`.
I think this change is a bit beyond the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
