silundong commented on PR #4392: URL: https://github.com/apache/calcite/pull/4392#issuecomment-2986406394
> I had suggested a test that validates all candidate hypergraphs, even the non-optimal ones, to improve the coverage of the code. I didn't see one. Is it possible to add one? https://github.com/apache/calcite/blob/0c238dcb0229d6797bf2818ab08cf9ed766c234c/core/src/main/java/org/apache/calcite/rel/rules/DpHyp.java#L360 I added assert during the enumeration process to verify the rowType of each candidate result. Is this ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
