silundong commented on code in PR #4392: URL: https://github.com/apache/calcite/pull/4392#discussion_r2155836461
########## core/src/main/java/org/apache/calcite/rel/rules/ConflictRule.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.rules; + +/** + * A conflict rule (CR) is a pair of table sets denoted by T1 → T2, which means that if T1 + * intersects with the table under the join operator, T2 must be included in this join. With every + * hyperedge in hypergraph, we associate a set of conflict rules. + * + * @see HyperEdge + * @see ConflictDetectionHelper + */ +public class ConflictRule { + Review Comment: I think it may emphasize the meaning of **node set** more. What do you think of _this is a bitmap where indexes refer to input of hypergraph_? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
