NobiGo commented on code in PR #4430:
URL: https://github.com/apache/calcite/pull/4430#discussion_r2160909352
##########
core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java:
##########
@@ -529,9 +529,6 @@ private boolean inputContainsSubQueryTables(Project
project, RelNode input) {
Set<List<String>> subQueryTables = inputSubQueryTablesCollector.tables();
- assert subQueryTables.isEmpty() || subQueryTables.size() == 1
Review Comment:
You can try removing the SubQueryRemoveRule. Multiple tables should be easy
to simulate. I hope there can be some test cases that can cover this change.
Secondly, if this is an abnormal situation for the user, we can replace
assert with Preconditions to ensure that an exception is thrown when this
condition is not applicable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
