xiedeyantu commented on code in PR #4430:
URL: https://github.com/apache/calcite/pull/4430#discussion_r2160771199


##########
core/src/test/resources/sql/scalar.iq:
##########
@@ -302,7 +302,6 @@ from (values (1), (3)) t1(id);
 !ok
 
 # Several scalar sub-queries reference different tables in FROM list
-!if (false) {

Review Comment:
   @NobiGo This is the issue mentioned by Mihai. After CALCITE-7009 is merged, 
this case will report an error. He promptly fixed the issue of the main branch 
error by temporarily skipping. In my opinion, it is because 
[CALCITE-7009](https://github.com/apache/calcite/pull/4378) allows for some 
assert judgments and there is no rebase main branch during merging. I tried 
debugging this issue and found that there was an assert in 
[CALCITE-5638](https://github.com/apache/calcite/pull/4328) that failed. I 
guess it's possible that some restrictions were lifted in 
[CALCITE-7009](https://github.com/apache/calcite/pull/4378), which caused 
issues with subsequent assertions. So the problem may not necessarily exist in 
[CALCITE-7009](https://github.com/apache/calcite/pull/4378). I don't know if my 
fix is appropriate, I just want to raise this issue and try to solve it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to