xiedeyantu commented on code in PR #4465:
URL: https://github.com/apache/calcite/pull/4465#discussion_r2208943640
##########
core/src/main/java/org/apache/calcite/plan/RelOptPredicateList.java:
##########
@@ -104,6 +106,36 @@ private RelOptPredicateList(ImmutableList<RexNode>
pulledUpPredicates,
this.rightInferredPredicates =
requireNonNull(rightInferredPredicates, "rightInferredPredicates");
this.constantMap = requireNonNull(constantMap, "constantMap");
+
+ // Validate invariants required
+ // (unfortunately the style rules don't allow us to move this to a
separate function).
+ // Do not allow comparisons with null literals in pulledUpPredicates
+ for (RexNode predicate : this.pulledUpPredicates) {
Review Comment:
The constructor of the current class is private. If this class can only be
created through the `of` method, can this code be moved to the `of` method and
encapsulated into a new method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
