xiedeyantu commented on code in PR #4465:
URL: https://github.com/apache/calcite/pull/4465#discussion_r2209004286
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -645,6 +645,11 @@ private <C extends Comparable<C>> RexNode
simplifyComparison(RexCall e,
}
}
+ RexNode node = simplifyComparisonWithNull(e, unknownAs);
Review Comment:
Maybe it will be easier to understand if it is simplified. Or put the logic
of this method directly in `simplifyComparison` instead of making it a separate
method? This is just my personal suggestion and it does not have to be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
