julianhyde commented on code in PR #4478:
URL: https://github.com/apache/calcite/pull/4478#discussion_r2231598028
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -739,6 +741,8 @@ void populate1() {
NullPolicy.STRICT);
defineMethod(BITXOR, BuiltInMethod.BIT_XOR.method,
NullPolicy.STRICT);
+ defineMethod(LEFTSHIFT, LEFT_SHIFT.method,
+ NullPolicy.STRICT);
Review Comment:
Right between two methods that start with BIT??! really?
Use the BuilInMethod qualifier, like the other code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
