julianhyde commented on code in PR #4478:
URL: https://github.com/apache/calcite/pull/4478#discussion_r2231606521
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3416,6 +3417,111 @@ public static ByteString bitNot(ByteString b) {
return new ByteString(result);
}
+ /**
+ * Checks if the shift count is negative.
Review Comment:
It doesn’t “check”, it throws.
There needs to be a blank line before this method. You have messed up blank
lines in a couple other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
