michalstutzmann commented on code in PR #4501:
URL: https://github.com/apache/calcite/pull/4501#discussion_r2295705865
##########
core/src/main/java/org/apache/calcite/sql/type/FunctionSqlType.java:
##########
@@ -58,6 +58,10 @@ public FunctionSqlType(
return this;
}
+ public RelDataType getParameterType() {
Review Comment:
It looks like the the `parameterType` is required to be a struct type
because of this line that uses `getFieldList`:
https://github.com/apache/calcite/blob/136273fa20b05720db79fb0952772158e8764bb9/core/src/main/java/org/apache/calcite/sql/type/FunctionSqlType.java#L48
This means the function type already supports multiple parameters via the
struct. I haven't added the array/collection then.
Have added a test and an additional check for the struct. Please let me know
what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
