michalstutzmann commented on code in PR #4501:
URL: https://github.com/apache/calcite/pull/4501#discussion_r2300844354
##########
core/src/main/java/org/apache/calcite/sql/type/FunctionSqlType.java:
##########
@@ -58,6 +58,10 @@ public FunctionSqlType(
return this;
}
+ public RelDataType getParameterType() {
Review Comment:
Two (soft) reasons against this approach:
- convention: `RelDataType.isStruct()` is used across the source code in
similar scenarios, e.g.:
https://github.com/apache/calcite/blob/87789d949ff305aa5eacc9e6bd835b4f25bcd769/core/src/main/java/org/apache/calcite/rex/RexProgramBuilder.java#L77
- `RelDataTypeImpl.getFieldList() on non-struct type throws `AssertionError`
https://github.com/apache/calcite/blob/87789d949ff305aa5eacc9e6bd835b4f25bcd769/core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java#L193
I'm open to do it any way you see it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
